Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Master] Improve the order of completions for client resource access action statements #42551

Merged
merged 3 commits into from
May 14, 2024
Merged

[Master] Improve the order of completions for client resource access action statements #42551

merged 3 commits into from
May 14, 2024

Conversation

nipunayf
Copy link
Contributor

@nipunayf nipunayf commented Apr 15, 2024 •
edited
Loading

Purpose

Expanding on the work initiated in #41636, support has been broadened to client resource access action statements.

Fixes #42549

Samples

image image

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@nipunayf nipunayf requested a review from mohanvive as a code owner April 15, 2024 19:13
@nipunayf nipunayf changed the title Improved the order of completions for parameterless client resource access actions Improved the order of completions for client resource access action statements Apr 15, 2024
@nipunayf nipunayf added the Team/LanguageServer Language Server Implementation related issues. #Compiler label Apr 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 4, 2024

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label May 4, 2024
@nipunayf nipunayf removed the Stale label May 4, 2024
@dulajdilshan dulajdilshan changed the title Improved the order of completions for client resource access action statements Improve the order of completions for client resource access action statements May 9, 2024
KavinduZoysa
KavinduZoysa previously approved these changes May 9, 2024
View reviewed changes
@KavinduZoysa
Copy link
Contributor

KavinduZoysa commented May 9, 2024 •
edited
Loading

@nipunayf Please update the PR with the master.

@nipunayf nipunayf changed the title Improve the order of completions for client resource access action statements [Master] Improve the order of completions for client resource access action statements May 10, 2024
dulajdilshan
dulajdilshan reviewed May 10, 2024
View reviewed changes
...rinalang/langserver/completions/providers/context/ClientResourceAccessActionNodeContext.java
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we considering alphabetic order or any other order when re-ordering resource-function paths?

Copy link
Contributor Author

@nipunayf nipunayf May 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ATM there are no such explicit sorts, and we are preserving the order in which the user has defined the resource methods in the class.

@codecov Codecov
Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.19%. Comparing base (dca7201) to head (7d40624).
Report is 82 commits behind head on master.

Files Patch % Lines
...context/ClientResourceAccessActionNodeContext.java 94.11% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master   #42551      +/-   ##
============================================
+ Coverage     77.13%   77.19%   +0.05%     
- Complexity    51182    51285     +103     
============================================
  Files          2924     2929       +5     
  Lines        203973   204413     +440     
  Branches      26604    26663      +59     
============================================
+ Hits         157338   157797     +459     
+ Misses        38122    38055      -67     
- Partials       8513     8561      +48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nipunayf nipunayf merged commit 5a64f76 into ballerina-platform:master May 14, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulajdilshan dulajdilshan dulajdilshan left review comments

@KavinduZoysa KavinduZoysa KavinduZoysa approved these changes

@mohanvive mohanvive Awaiting requested review from mohanvive

@LakshanWeerasinghe LakshanWeerasinghe Awaiting requested review from LakshanWeerasinghe

@mindula mindula Awaiting requested review from mindula

Assignees
No one assigned
Labels
Team/LanguageServer Language Server Implementation related issues. #Compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Completion items are not properly ordered for client resource access actions
3 participants
@nipunayf @KavinduZoysa @dulajdilshan